Repository navigation
Unified: Nested type aliases are static members - #22877
Merged
Merged
Conversation
asgerf
approved these changes
Oct 23, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow classification change fits the existing alias-resolution logic and includes targeted regression coverage, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates Unified name binding so nested Swift type aliases resolve as static members of their enclosing types.
Changes:
- Classifies nested type aliases as static members.
- Adds regression coverage for
A.BAlias.Cand reformats the existing Swift fixture.
| File | Description |
|---|---|
| unified/ql/test/library-tests/static-name-binding/test.swift | Tests nested alias access and subsequent member resolution. |
| unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll | Adds type aliases to static-member classification. |
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.