Skip to content

Unified: Nested type aliases are static members #22877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 2 commits into from
Oct 23, 2026
+42 −36
Merged

Unified: Nested type aliases are static members #22877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a05b3ee
Unified: Add name binding test for nested alias
hvitved Oct 23, 2026
fa5555b
Unified: Nested type aliases are static members
hvitved Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ predicate isInstanceMember(Member member) {
*/
predicate isStaticMember(Member member) {
exists(ClassLikeDeclaration cls | cls.getAMember() = member |
not any(NameBindingPlugin p).isInstanceMember(cls, member)
or
member instanceof ConstructorDeclaration
not any(NameBindingPlugin p).isInstanceMember(cls, member) or
member instanceof ConstructorDeclaration or
member instanceof TypeAliasDeclaration
)
or
member = any(TopLevel t).getBody().getAStmt()
Expand Down
72 changes: 39 additions & 33 deletions unified/ql/test/library-tests/static-name-binding/test.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
class B {} // name=top.B
class B {} // name=top.B

class A {
class B {
class C {}
}

typealias BAlias = B // $ access=A.B
}

let x1: B = nil; // $ access=top.B
let x2: A.B = nil; // $ access=A access=A.B
let x3: A.B.C = nil; // $ access=A access=A.B access=A.B.C
let x1: B = nil // $ access=top.B
let x2: A.B = nil // $ access=A access=A.B
let x3: A.B.C = nil // $ access=A access=A.B access=A.B.C
let x4: A.BAlias.C = nil // $ access=A access=A.BAlias access=A.B.C

class D {
let x1: B = nil; // $ access=top.B
let x2: A.B = nil; // $ access=A access=A.B
let x3: A.B.C = nil; // $ access=A access=A.B access=A.B.C
let x1: B = nil // $ access=top.B
let x2: A.B = nil // $ access=A access=A.B
let x3: A.B.C = nil // $ access=A access=A.B access=A.B.C

func member() {
let x1: B = nil; // $ access=top.B
let x2: A.B = nil; // $ access=A access=A.B
let x3: A.B.C = nil; // $ access=A access=A.B access=A.B.C
let x1: B = nil // $ access=top.B
let x2: A.B = nil // $ access=A access=A.B
let x3: A.B.C = nil // $ access=A access=A.B access=A.B.C
}
}

Expand All @@ -28,49 +31,52 @@ class E {
}
}

let x1: A = nil; // $ access=E.A
let x2: A.B = nil; // $ access=E.A access=E.A.B
let x1: A = nil // $ access=E.A
let x2: A.B = nil // $ access=E.A access=E.A.B
}

class F {
static let field = 1
static let (a,b) = (1,2)
static let (a, b) = (1, 2)

static func foo() {
F.field // $ access=F access=F.field
F.a // $ access=F access=F.a
F.b // $ access=F access=F.b
F.field // $ access=F access=F.field
F.a // $ access=F access=F.a
F.b // $ access=F access=F.b
}
}

typealias G = A // $ access=A
typealias G = A // $ access=A

// Members can be accessed through aliases, but references to the alias itself do not bypass the alias.
class H { // name=H1
let x1: G = nil; // $ access=G
let x2: G.B = nil; // $ access=G access=A.B
let x3: G.B.C = nil; // $ access=G access=A.B access=A.B.C
class H { // name=H1
let x1: G = nil // $ access=G
let x2: G.B = nil // $ access=G access=A.B
let x3: G.B.C = nil // $ access=G access=A.B access=A.B.C
}

enum I {
case one=1, two=2
case three=3
case one = 1
case two = 2
case three = 3
}

func useI() {
I.one // $ access=I access=I.one
I.two // $ access=I access=I.two
I.three // $ access=I access=I.three
I.one // $ access=I access=I.one
I.two // $ access=I access=I.two
I.three // $ access=I access=I.three
}

protocol P { }
protocol P {}

extension H // $ access=H1
: P { } // $ access=P
extension H // $ access=H1
: P // $ access=P
{}

extension A.B.C // $ access=A access=A.B access=A.B.C
: P { } // $ access=P
extension A.B.C // $ access=A access=A.B access=A.B.C
: P // $ access=P
{}

A() // $ access=A
A() // $ access=A

A.init() // $ access=A access=A.init
A.init() // $ access=A access=A.init
Loading