Skip to content

P0 PTP–SV: fail closed on stale 1Hz phase observer while 4kHz SV continues - #254

Closed
masarray wants to merge 3 commits into
fix/p0-sv-reject-unverified-start-20261019from
fix/p0-ptp-sv-phase-freshness-20261020
Closed

masarray wants to merge 3 commits into
fix/p0-sv-reject-unverified-start-20261019from
fix/p0-ptp-sv-phase-freshness-20261020

Conversation

@masarray

@masarray masarray commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #252, no main merge. Source-level failure: publisher previously trusted a cached phase_authority_valid indefinitely if the 1Hz phase observer stopped but 4kHz TX and PTP source generation continued. Add last independently observed phase epoch publication and O(1) per-frame freshness guard; source/timing fault still revokes immediately, no new ISR/blocking/mac TX work. Portable stall/rollover tests. This does NOT explain old physical 0→1→0→1, prove fast acquisition or qualify real relay; DEFAULT/PREVIEW builds distinct; 120s/3600s joint SV+PTP hardware and GM/IED proof remain required.


2026-10-23 PR cleanup — historical stack checkpoint, superseded by #286. GitHub compare proves HEAD 50c6e347a465506a96798276c64b5a8649c3d518 is an ancestor of draft #286 at 3c8b76de2bb5cc3d097c8975d3748e96fc0d35ec (0 commits unique to this PR head, behind_by=0). Closing its PR only; branch and code/history are preserved, no merge to main. Independent/divergent feature branches stay open. Hardware relay acceptance remains pending.

@masarray
masarray marked this pull request as ready for review October 20, 2026 04:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T04:04:40.531320Z 50c6e34 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant