Skip to content

test: fix TLS coalescing test for OpenSSL 4.1 - #66962

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:test-tls-coalesce-openssl-4.1
Open

panva wants to merge 1 commit into
nodejs:mainfrom
panva:test-tls-coalesce-openssl-4.1

Conversation

@panva

@panva panva commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 23, 2026
@panva panva added fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please πŸ‘ to approve.

@panva

panva commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

Asking for fast-track to have this on main before starting the 4.1 PR clock such that 4.1 can be on the first 27.x alpha in time.

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 23, 2026
@richardlau richardlau added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Oct 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva

panva commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

I don't believe lts-watch applies here, the test is new, it's not going to reach 22 and unlikely to reach 24 at this point in its transition to maintenance either.

@panva panva removed lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Oct 23, 2026
@richardlau

Copy link
Copy Markdown
Member

I don't believe lts-watch applies here, the test is new, it's not going to reach 22 and unlikely to reach 24 at this point in its transition to maintenance either.

Maybe dont-land labels then?

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.59%. Comparing base (03cca65) to head (ca4e29d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66962      +/-   ##
==========================================
+ Coverage   90.58%   90.59%   +0.01%     
==========================================
  Files         797      797              
  Lines      278297   278297              
  Branches    53515    53501      -14     
==========================================
+ Hits       252096   252127      +31     
+ Misses      16561    16525      -36     
- Partials     9640     9645       +5     

see 35 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants