Repository navigation
Make the PySide2 compatibility requirement optional - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the existing PySide2 version compatibility constraint into the pyside2 extra so users can opt into enforcement by dependency resolvers. Preserve the existing declared lower bound of PySide2 5.11.0.
Document compatibility enforcement as the purpose of the extra. Selecting it may also cause pip to install or change PySide2 as a side effect of satisfying the constraint. Record the change in the changelog. Base installations no longer require PySide2; the existing mypy requirement and development extra remain unchanged.
Validation: Built a wheel and source distribution with Python 3.12 and setuptools 75.8.0. Verified that the binding requirement is conditional on the extra, its version bound and other dependencies are preserved, and all 50 packaged stub files are byte-for-byte identical to the base branch. Reviewed the documentation correction and checked whitespace.