Repository navigation
fix: load v13 API docs from published compiler data - #1458
Open
fhammerschmidt wants to merge 1 commit into
Open
fhammerschmidt wants to merge 1 commit into
fhammerschmidt wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fhammerschmidt
force-pushed
the
fix/1433-v13-api-data
branch
from
October 20, 2026 16:24
7037429 to
f63e48e
Compare
Build on the shared website sync to select v13 publications, preview labels, search metadata, and generated manual indexes from DocsVersion.current. Add ReScript tests for publication selection, route loaders, data URLs, sidebars, and link validation. Remove the now-unused major-version helper. Fixes rescript-lang#1433
fhammerschmidt
force-pushed
the
fix/1433-v13-api-data
branch
from
October 20, 2026 17:13
f63e48e to
88bef84
Compare
jderochervlk
approved these changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared API-data loader and cleanup landed in #1459. On the updated
v13baseline, select repository-rootdata/api/v13.*publications for the v13 website and useDocsVersion.currentfor the preview label, search metadata, and generated manual indexes. Keep a link to the released v12 documentation and remove the unused major-version display helper.Add ReScript regression coverage for numeric v13 publication selection without mixing compiler majors, generated route types, API roots/modules and sidebar content across document/data URLs, and API link validation. The existing shared validation still rejects incomplete and malformed publications. No API snapshot JSON is deleted or changed by this follow-up.
Fixes #1433.
Prepares the website for compiler #8753, which should follow after this lands.