Repository navigation
Conversation
edalzell
force-pushed
the
fix/replicator-collapsed-meta
branch
from
October 21, 2026 02:21
8d0b9e4 to
3079306
Compare
edalzell
force-pushed
the
fix/replicator-collapsed-meta
branch
from
October 21, 2026 02:33
3079306 to
a143ca0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggling a single Replicator set never reached
meta.collapsed.collapseSet/expandSetmutate the array in place and the watcher that writes it to meta was shallow, so it only fired on reassignment (collapse all, expand all, accordion). Any remount of the field, e.g. a Replicator inside a Bard set, or toggling fullscreen, re-read the stale meta and snapped expanded sets shut.The watcher is now
deep, so in-place toggles go throughupdate:metalike the bulk actions already do.Stopping Bard from remounting sets in the first place is #15689.
Closes #15687