Repository navigation
Remind about approvals waiting 15 min, switch each notification kind, one notification per chat - #492
Merged
Birfy merged 3 commits intoOct 20, 2026
Conversation
… one notification per chat (ThinkFlowLab#469)
Collaborator
Author
|
Self-review: PASS
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 20, 2026
ThinkFlowLab#481/ThinkFlowLab#501/ThinkFlowLab#505) Regenerated ds-bot patches after merge.
Collaborator
Author
|
Self-review: PASS
|
Keep ThinkFlowLab#469 per-kind notify prefs in host docs; take main's ThinkFlowLab#471 trimEnded endedView description. Regenerate client bundle and ds-bot patches.
Collaborator
Author
|
Self-review: PASS
|
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469 (first slice, owner decision 2026-10-20 option a). Builds on #353's notifications (#470). Quiet hours, mute and an in-app list stay for later; friends'/team notifications wait for #51.
What
Coder has waited 15 min for your approval. A client timer is set for the next due approval and cleared with the effect; a decided approval gets none.prefs.notify, on unlessfalse; disabled while the main switch is off).set-prefstakesnotify: { approval | finished | failed: boolean }, keeps only the off ones.ds-bot-<chat id>, so a newer one replaces the older, and the body counts the updates (3 updates) since the chat was last on screen or its notification clicked. Several events of one chat in one pass become one notification (the newest).Test
core/test/approval-notices.test.js(reminder timing and cleanup, reminder for pre-window approvals, per-kind switches, per-chat collapse and count reset, Settings rows) andinstall.test.js(set-prefs notify).ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1082, social 296, tree 80, timeline 83, scripts 93, interop 37, live-e2e 16; 0 failures).changelog.mjs check: ok.Risk tier: T2 (estimate; the controller sets the label)