Repository navigation
Notify when my own Bots finish or fail a turn, with one Notifications switch - #470
Merged
Birfy merged 4 commits intoOct 20, 2026
Merged
Conversation
Collaborator
Author
|
Self-review: PASS
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 20, 2026
This was referenced Oct 20, 2026
…notifications # Conflicts: # patches/ds-bot/0008-client-bundle.patch # patches/ds-bot/topics.json
Birfy
enabled auto-merge
October 20, 2026 02:39
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 20, 2026
Collaborator
Author
|
Self-review PASS (after merging main 465357e): merged
|
…notifications # Conflicts: # patches/ds-bot/0008-client-bundle.patch
Birfy
enabled auto-merge
October 20, 2026 02:44
Collaborator
Author
|
Self-review PASS (after merging main c7898dd): merged
|
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353 (first slice, owner decision 2026-10-20 option a). The rest of #353 (quiet hours, mute, waiting too long, per-trigger switches, merging repeats, friends'/team reminders) is tracked in #469.
What
Coder finished/Coder failed: <reason>(the group name as body for a group turn). Clicking it focuses the window and opens that chat or group. It carries no buttons and never approves, rejects or sends anything.core/src/client/approval-notices.js): only if the OS already allows notifications (never asks), one per event (tag), nothing from before the window opened.turns.jskeeps the last 20 ended turns (endedView, process-local) and they ridelive().work.ended;ownedLivekeeps only the actor's own Bots. Left out: stopped, switched and retried turns, a friend's Bot, turns a friend started, hidden turns another Bot asked for, face-to-face / inbound-share rooms.prefs.notifications), covering approval waiting too.Test
core/test/approval-notices.test.js(client rules, switch, host filter);authz.test.js(narrowing) andinstall.test.js(set-prefs).ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1033, social 291, tree 80, timeline 80, scripts 88, interop 37, live-e2e 16; 0 failures).Risk tier: T2 (estimate; the controller sets the label)